Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement VM snapshots #379

Merged
merged 15 commits into from
Jul 14, 2023
Merged

Implement VM snapshots #379

merged 15 commits into from
Jul 14, 2023

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Jul 13, 2023

Implement VM snapshots that will be managed independently by a snapshot manager.

…le and share this data.

Feature: Implement VM snapshots that will be managed independently.
@nesitor nesitor requested review from hoh and odesenfans July 13, 2023 13:18
@nesitor nesitor self-assigned this Jul 13, 2023
vm_supervisor/pool.py Outdated Show resolved Hide resolved
vm_supervisor/snapshots.py Outdated Show resolved Hide resolved
vm_supervisor/snapshots.py Outdated Show resolved Hide resolved
vm_supervisor/storage.py Outdated Show resolved Hide resolved
vm_supervisor/storage.py Outdated Show resolved Hide resolved
vm_supervisor/storage.py Show resolved Hide resolved
vm_supervisor/vm/firecracker/instance.py Outdated Show resolved Hide resolved
vm_supervisor/vm/firecracker/instance.py Outdated Show resolved Hide resolved
vm_supervisor/snapshots.py Outdated Show resolved Hide resolved
@nesitor nesitor requested a review from odesenfans July 13, 2023 19:37
Copy link
Collaborator

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking clean, just a few more comments.

vm_supervisor/pool.py Outdated Show resolved Hide resolved
vm_supervisor/snapshots.py Outdated Show resolved Hide resolved
vm_supervisor/storage.py Outdated Show resolved Hide resolved
vm_supervisor/storage.py Outdated Show resolved Hide resolved
@nesitor nesitor requested a review from odesenfans July 14, 2023 11:23
@nesitor nesitor marked this pull request as ready for review July 14, 2023 11:55
nesitor and others added 7 commits July 14, 2023 14:03
)

Problem: the CI is looking for only one lock file, but apt/dpkg use several. Furthermore, `lslocks --json` seems to cut its output to a specific width, and configuration options (`--notruncate`) do not appear to have an impact.

Solution: repeat calls to apt-get update until we get the lock. This is not perfect but increases the rate of success.
Updated creation script to create a BTRFS image of Ubuntu filesystem.
Added support for BTRFS to execute a VM instance.
@nesitor nesitor merged commit 0c85e9a into main Jul 14, 2023
12 checks passed
hoh added a commit that referenced this pull request Mar 12, 2024
* Problem: Instances loose data between nodes, so we need a way to handle and share this data.

Feature: Implement VM snapshots that will be managed independently.

* Fix: Added some refactor for snapshots and handled some errors.

* Fix: Split snapshot class in two.

* Fix: Make it work well with threads and asyncio.

* Fix: Added code improvements with threading and fixed PR comments.

* Fix: Fixed check_disk method error.

* Fix: Fixed more snapshot errors with multithreading

* Fix: CI for Ubuntu was failing too often because of apt/dpkg locks (#380)

Problem: the CI is looking for only one lock file, but apt/dpkg use several. Furthermore, `lslocks --json` seems to cut its output to a specific width, and configuration options (`--notruncate`) do not appear to have an impact.

Solution: repeat calls to apt-get update until we get the lock. This is not perfect but increases the rate of success.

* Create Ubuntu rootfs (#370)

Updated creation script to create a BTRFS image of Ubuntu filesystem.

* Fix: Use SDK version 0.7.0 (#371)

* Support BTRFS filesystem for instances (#373)

Added support for BTRFS to execute a VM instance.

* Feature: Delete old snapshots after do a new one.

* add dependency to python3-schedule

* Fix latest_snapshot attribute error

* default snapshot frequency 1 hour

---------

Co-authored-by: Olivier Desenfans <[email protected]>
Co-authored-by: Hugo Herter <[email protected]>
Co-authored-by: Andres D. Molins <[email protected]>
@Psycojoker Psycojoker deleted the andres-add-vm-snapshots branch July 24, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants